Skip to content

feat!: patternfly elements v5#3113

Merged
bennypowers merged 15 commits intomainfrom
staging/pfe5
Apr 29, 2026
Merged

feat!: patternfly elements v5#3113
bennypowers merged 15 commits intomainfrom
staging/pfe5

Conversation

@zeroedin
Copy link
Copy Markdown
Collaborator

What I did

Testing Instructions

Notes to Reviewers

bennypowers and others added 11 commits April 15, 2026 15:23
Rename all 35 elements and their sub-components from pf-* to pf-v5-*.
CSS custom properties renamed from --pf-c-* to --pf-v5-c-*.
Global tokens (--pf-global--*) are unchanged.

Closes #3052, closes #3053, closes #3054, closes #3055,
closes #3056, closes #3057, closes #3058, closes #3059,
closes #3060, closes #3061, closes #3062, closes #3063,
closes #3064, closes #3065, closes #3066, closes #3067,
closes #3068, closes #3069, closes #3070, closes #3071,
closes #3072, closes #3073, closes #3074, closes #3075,
closes #3076, closes #3077, closes #3078, closes #3079,
closes #3080, closes #3081, closes #3082, closes #3083,
closes #3084, closes #3085, closes #3086

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* feat!: remove bundled entrypoint (pfe.min.js)

The bundled entrypoint causes custom element double-registration
issues and is not the recommended way to consume the library.

Closes #3087

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: remove bundle references from docs plugin

Remove the bundle() call and pfe.min.* passthrough copies
from the Eleventy docs plugin, since the bundled entrypoint
was removed.

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: remove trailing blank line in pfe-assets plugin

Fixes padded-blocks lint error.

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Update all docs site references to use the new pf-v5-* element names,
including HTML tags, CSS selectors, import paths, and code examples.

Blog posts and changelogs left unchanged as historical records.
PF4 core CSS tokens (--pf-c-content/title/text) left unchanged as
they reference the PF CSS framework, not pf-elements components.

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Update main.mjs to import PfV5Icon from renamed path
- Update pfe-assets.cjs regex and JSDoc for pf-v5-* paths
- Pass prefix option to PfeAssetsPlugin in eleventy config
- Replace broken generateImportMap shortcodes with static import
  maps (jspm.io can't resolve unpublished pf-v5-* paths)
- Fix pre-existing TS build errors: use Router.Middleware instead
  of non-existent RouterMiddleware export, remove stale
  @ts-expect-error directive
- Fix pre-existing slug function call using deprecated
  eleventyConfig.javascript.functions API

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Remove CascadeController and @Cascades decorator (use @lit/context)
- Remove SlotController.anonymous (use SlotController.default)
- Remove pf-popover closeButtonLabel / close-label attribute
  (use accessible-close-label)

pfeCustomElementsManifestConfig was already removed from the codebase.

Closes #2975, closes #2974, closes #2973, closes #2972

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Use koa Middleware type instead of Router.Middleware namespace
  (namespace not available with Node moduleResolution)
- Use @ts-ignore instead of @ts-expect-error for colorjs.io import
  (error occurs on CI but not locally due to moduleResolution)

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Apply pf-v5-* rename rules to all incoming changes from main:
- label: link variant, hover borders, icon colors, link.html demo
- switch: accessible-label property and tests
- popover: outsideClick guard for hidden popovers
- table: columnheader role fix, toggle button a11y
- tabs: passive scroll event listeners
- jump-links: landmark label with part attribute
- select: replace rh-color tokens with pf-global tokens
- back-to-top: hover/focus background color, pf-button selectors
- core: SlotController fix

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
`@sindresorhus/slugify` v2 is ESM-only. Node 22 `require()` of ESM
returns the module namespace object, not the default export, causing
`TypeError: slugify is not a function` in the eleventy `ids` transform.

Assisted-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
- README: update test path examples to pf-v5-* element dirs
- elements/package.json: remove orphaned pf-jazz-hands export entry
- eslint.config.js: fix pf-icon ignore path to pf-v5-icon
- bundle.ts: update pf-icon export to pf-v5-icon
- dev server index.html template: update pf-button/pf-icon/pf-card tags
  and imports to pf-v5-* equivalents
- docs/_snippets: update accordion-jsx and card-html import paths
- vue.md: fix CodeSandbox search hint to @patternfly/elements

Assisted-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 28, 2026

🦋 Changeset detected

Latest commit: 36cc662

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@patternfly/elements Major
@patternfly/pfe-core Major
@patternfly/pfe-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 28, 2026

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 9c0b2bc
😎 Deploy Preview https://deploy-preview-3113--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@zeroedin zeroedin changed the title staging/pfe5 staging: pfe5 Apr 28, 2026
@github-actions github-actions Bot added the AT passed Automated testing has passed label Apr 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

SSR Test Run for 43d3672: Report

@bennypowers bennypowers changed the title staging: pfe5 feat!: patternfly elements v5 Apr 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 28, 2026

✅ Commitlint tests passed!

More Info
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "feat!: patternfly elements v5"
}

feat!: rename all elements to pf-v5-* prefix
@github-actions
Copy link
Copy Markdown
Contributor

SSR Test Run for b9d1c27: Report

…3114)

* docs: rename doc files to match pf-v5 element names

* chore: update tagPrefix in config

* fix: use unbundled element modules for docs site

* refactor(tools): use pfe config for tag aliasing in DocsPage

* chore(tools): add changeset

* chore: correct npm run docs to include the elements build

* fix: copy element screenshots to docs site

* fix: copy demo assets to docs site
@github-actions
Copy link
Copy Markdown
Contributor

SSR Test Run for 878d01b: Report

* fix: strip v5 prefix from docs titles, replace @jspm/generator with @pwrs/mappa

Strip the tag prefix (pf-v5-) from element display names in the docs
site sidebar, page titles, and demo headings so they show "Accordion"
instead of "V5 Accordion".

Replace @jspm/generator with @pwrs/mappa for import map generation in
both the 11ty docs build and the dev server plugin. This fixes the
"Unable to resolve npm:lit@3.3.2" build error and simplifies the import
map infrastructure.

Also adds v5 to the docs version dropdown and marks it as current.

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: remove stale @jspm/generator patch file

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: lint errors in create-import-map and package.json sort order

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: operator-linebreak style in create-import-map

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions

This comment has been minimized.

@bennypowers bennypowers enabled auto-merge (squash) April 29, 2026 20:27
@bennypowers bennypowers merged commit 73b2389 into main Apr 29, 2026
24 checks passed
@bennypowers bennypowers deleted the staging/pfe5 branch April 29, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants